Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newsboat: fetch from vcs #76175

Merged
merged 1 commit into from Dec 25, 2019
Merged

newsboat: fetch from vcs #76175

merged 1 commit into from Dec 25, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Dec 22, 2019 •
edited

Motivation for this change

In hopes of working around
#60845. This fetches a gz archive
instead of xz and also fetches the archive from a different source,
hopefully avoiding the issue (whatever ist is caused by).

In addition to that, I think that building directly from VCS is
generally cleaner and more flexible for the following reasons:

  • It cuts out and unnecessary middle step.

  • It makes sure the version users install is equal to the version users
    may have vetted.

  • It makes it easy to develop patches or bisect changes by simply
    checking out a different rev.

  • It avoids using upstream-provided "binary" artifacts like those
    generated by autotools.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@timokau
newsboat: fetch from vcs
b747a86 
In hopes of working around
NixOS#60845. This fetches a gz archive
instead of xz and also fetches the archive from a different source,
hopefully avoiding the issue (whatever ist is caused by).

In addition to that, I think that building directly from VCS is
generally cleaner and more flexible for the following reasons:

- It cuts out and unnecessary middle step.

- It makes sure the version users install is equal to the version users
may have vetted.

- It makes it easy to develop patches or bisect changes by simply
checking out a different rev.

- It avoids using upstream-provided "binary" artifacts like those
generated by autotools.
@ofborg ofborg bot requested a review from dotlambda December 22, 2019 15:51
@timokau timokau mentioned this pull request Dec 22, 2019
Closed
@dywedir dywedir merged commit 1e8fa43 into NixOS:master Dec 25, 2019
@timokau timokau deleted the newsboat-from-vcs branch December 25, 2019 23:19
@timokau timokau restored the newsboat-from-vcs branch December 25, 2019 23:19
@timokau timokau deleted the newsboat-from-vcs branch December 25, 2019 23:19
@timokau timokau restored the newsboat-from-vcs branch December 25, 2019 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @dywedir