Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnunet: 0.11.8 -> 0.12.0 #76309

Merged
merged 1 commit into from Dec 27, 2019
Merged

gnunet: 0.11.8 -> 0.12.0 #76309

merged 1 commit into from Dec 27, 2019

Conversation

mehlon
Copy link
Contributor

@mehlon mehlon commented Dec 23, 2019 •
edited

Motivation for this change

Closes #76144

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vrthra

@ofborg ofborg bot requested a review from vrthra December 23, 2019 21:08
@mehlon
Copy link
Contributor Author

mehlon commented Dec 25, 2019 •
edited

I've used this a bunch and it works. Make sure to run with sudo.

gnunet-arm -s
gnunet-core

@nlewo
Copy link
Member

nlewo commented Dec 26, 2019

Since the 0.12 version can not peer with 0.11.8 version, I'm wondering if we should keep both of them or not (i'm not a gnunet user).
@vrthra WDYT?

@mehlon
Copy link
Contributor Author

mehlon commented Dec 26, 2019 •
edited

Keeping 0.11 around will be unnecessary. Almost all public bootstrap peers have been updated to 0.12. And the only other up-to-date packages for Arch and Homebrew do not keep around an old version. To clarify: every minor version change will be incompatible with the previous one: 0.10, 0.9, 0.8 ... are all incompatible with the latest gnunet.
https://www.archlinux.org/packages/community/x86_64/gnunet/
https://formulae.brew.sh/formula/gnunet#default

@nlewo nlewo merged commit 2002bf9 into NixOS:master Dec 27, 2019
@nlewo
Copy link
Member

nlewo commented Dec 27, 2019

@mehlon Thanks for your contribution and explanation!

@mehlon mehlon deleted the gnunet branch December 27, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
9.needs: maintainer feedback 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gnunet package update: 0.12.0
3 participants
@mehlon @nlewo @Janik-Haag