Commits on Dec 26, 2019

1. simplenote: fix libstdc++ error …

   Fixes a bug that was noticed during an automated version bump.
   
   What was needed was to add an LD_LIBRARY_PATH entry for stdenv.cc.cc in
   makeWrapper
   
   ```
   --prefix LD_LIBRARY_PATH : "${stdenv.lib.makeLibraryPath [ stdenv.cc.cc ] }" \
   ```
   
   The error as seen in developer tools console was:
   
   ```
   /nix/store/d4b2xcpdf4y4hspbwrmjdz540m493894-simplenote-1.12.0/opt/Simplenote/resources/electron.asar/renderer/init.js:158 Unable to load preload script: /nix/store/d4b2xcpdf4y4hspbwrmjdz540m493894-simplenote-1.12.0/opt/Simplenote/resources/app.asar/desktop/preload.js
   (anonymous) @ /nix/store/d4b2xcpdf4y4hspbwrmjdz540m493894-simplenote-1.12.0/opt/Simplenote/resources/electron.asar/renderer/init.js:158
   /nix/store/d4b2xcpdf4y4hspbwrmjdz540m493894-simplenote-1.12.0/opt/Simplenote/resources/electron.asar/renderer/init.js:159 Error: libstdc++.so.6: cannot open shared object file: No such file or directory
       at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:160:31)
       at Object.Module._extensions..node (internal/modules/cjs/loader.js:722)
       at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:169:18)
       at Module.load (internal/modules/cjs/loader.js:602)
       at tryModuleLoad (internal/modules/cjs/loader.js:541)
       at Function.Module._load (internal/modules/cjs/loader.js:533)
       at Module.require (internal/modules/cjs/loader.js:640)
       at require (internal/modules/cjs/helpers.js:20)
       at Object.<anonymous> (/nix/store/d4b2xcpdf4y4hspbwrmjdz540m493894-simplenote-1.12.0/opt/Simplenote/resources/app.asar/node_modules/@paulcbetts/spellchecker/lib/spellchecker.js:3)
       at Object.<anonymous> (/nix/store/d4b2xcpdf4y4hspbwrmjdz540m493894-simplenote-1.12.0/opt/Simplenote/resources/app.asar/node_modules/@paulcbetts/spellchecker/lib/spellchecker.js:116)
   ```
   To (help) anyone that may find have errors like this in the future:
   
   makeWrapper requiring the makeLibraryPath with stdenv.cc.cc is fairly common for electron apps.
   At least ones that use dpkg on prebuilt debian .deb files (my `bitwarden` derivation requires it, too) that use gappsWrapperArgs
   
   Thanks @ryantm / r-ryantm and @worldofpeace :)
   
   Reference: #76421 (review)

   

   Kiwi committed Dec 26, 2019
   Copy the full SHA

   cc20373 View commit details

   Browse the repository at this point in the history

2. Merge pull request #76558 from Kiwi/simplenote-fix …

   simplenote: fix libstdc++ error

   

   worldofpeace committed Dec 26, 2019
   Copy the full SHA

   ab322bb View commit details

   Browse the repository at this point in the history