Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.kexec: port to python and mark as broken #76560

Merged
merged 1 commit into from Jan 1, 2020
Merged

nixosTests.kexec: port to python and mark as broken #76560

merged 1 commit into from Jan 1, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Dec 27, 2019 •
edited

Motivation for this change

#72828

WIP Marking as broken because the test did not succeed for me before this commit (the Perl test hung forever), and this translation exhibits the same problem.

Maybe anyone knows more?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edolstra

@tfc tfc mentioned this pull request Dec 27, 2019
Closed
@worldofpeace
Copy link
Contributor

We don't have to fix every test in the port, you can mark it as broken.

@nh2
nixosTests.kexec: port to python.
12e3503 
The test did not succeed for me before this commit
(the Perl test hung forever), and this translation exhibits
the same problem.
@nh2
Copy link
Contributor Author

nh2 commented Dec 27, 2019

you can mark it as broken.

OK, added comment and removing WIP.

@nh2 nh2 changed the title [WIP] nixosTests.kexec: port to python. nixosTests.kexec: port to python and mark as broken Dec 27, 2019
@nh2
Copy link
Contributor Author

nh2 commented Dec 27, 2019 •
edited by worldofpeace

Trying anyway:

@GrahamcOfBorg test kexec

@flokli flokli merged commit 2393fa2 into NixOS:master Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nh2 @worldofpeace @flokli