Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.graphite: port to python and mark as broken #76562

Merged
merged 1 commit into from Jan 31, 2020
Merged

nixosTests.graphite: port to python and mark as broken #76562

merged 1 commit into from Jan 31, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Dec 27, 2019

Motivation for this change

The test did not succeed for me before this commit because
the dependencies fail their tests (see added comment, ImportError: No module named zope.interface for Twisted).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @basvandijk as main historic contributer

@nh2
nixosTests.graphite: port to python.
ad339ad 
The test did not succeed for me before this commit because
the dependencies fail their tests (see added comment).
@nh2 nh2 requested a review from basvandijk December 27, 2019 00:26
@tfc tfc mentioned this pull request Dec 27, 2019
Closed
@nh2
Copy link
Contributor Author

nh2 commented Dec 27, 2019 •
edited by worldofpeace

Trying anyway:

@GrahamcOfBorg test graphite

@worldofpeace
Copy link
Contributor

@nh2 you have to tell it which test to run.

@worldofpeace worldofpeace merged commit e8e946a into NixOS:master Jan 31, 2020
@worldofpeace worldofpeace added this to the 20.03 milestone Jan 31, 2020
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@worldofpeace @anna328p
Merge pull request NixOS#76562 from nh2/graphite-test-python
0640749 
nixosTests.graphite: port to python and mark as broken
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nh2 @worldofpeace