Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovim: Drop jemalloc #76301

Merged
merged 1 commit into from Dec 25, 2019
Merged

neovim: Drop jemalloc #76301

merged 1 commit into from Dec 25, 2019

Conversation

mmlb
Copy link
Contributor

@mmlb mmlb commented Dec 23, 2019

See neovim/neovim#9526.

Motivation for this change

Drop unneeded dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @manveru @rvolosatovs

@ofborg ofborg bot requested a review from manveru December 23, 2019 19:48
@teto
Copy link
Member

teto commented Dec 25, 2019

@GrahamcOfBorg build neovim-unwrapped

@teto teto merged commit b840977 into NixOS:master Dec 25, 2019
@mmlb mmlb deleted the neovim-drop-jemalloc branch February 13, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@manveru manveru Awaiting requested review from manveru

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmlb @teto @bhipple