Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyyaml: 5.1.2 -> 5.2.0 #76566

Closed
wants to merge 1 commit into from
Closed

pythonPackages.pyyaml: 5.1.2 -> 5.2.0 #76566

wants to merge 1 commit into from

Conversation

kamadorueda
Copy link
Member

@kamadorueda kamadorueda commented Dec 27, 2019 •
edited

  • Upgrade PyYAML to the current stable version
  • Tested in both python and python3

Closes #76564

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@kamadorueda
pythonPackages.pyyaml: 5.1.2 -> 5.2.0
c465f76 
- Upgrade PyYAML to the current stable version
- Tested in both python and python3

Closes #76564
@ofborg ofborg bot requested a review from dotlambda December 27, 2019 02:50
tomberek
tomberek reviewed Dec 28, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on NixOS with reverse dependency failures (~10%).

I have less experience with evaluating python version bumps to core packages. I like the PR, but am not sure how to ensure this does not break too many other packages.

@kamadorueda
Copy link
Member Author

will check that

@FRidh
Copy link
Member

FRidh commented Dec 29, 2019

Included in #76059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade python package: PyYAML
3 participants
@kamadorueda @FRidh @tomberek