Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texlab: fix macOS build #76544

Merged
merged 1 commit into from Dec 26, 2019
Merged

texlab: fix macOS build #76544

merged 1 commit into from Dec 26, 2019

Conversation

kira-bruneau
Copy link
Contributor

Motivation for this change

Should fix #76520, but I don't have a mac machine to test on.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @doronbehar

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 26, 2019
@ofborg ofborg bot requested a review from doronbehar December 26, 2019 17:17
@veprbl
Copy link
Member

veprbl commented Dec 26, 2019

@GrahamcOfBorg build texlab

@veprbl
Copy link
Member

veprbl commented Dec 26, 2019 •
edited

I guess CoreServices should go to the node_citeproc package.

@kira-bruneau
Copy link
Contributor Author

@veprbl I moved CoreServices over to citeproc.

@veprbl
Copy link
Member

veprbl commented Dec 26, 2019

Great. Let's give it another try.

@GrahamcOfBorg build texlab

@veprbl veprbl merged commit 690390d into NixOS:master Dec 26, 2019
@veprbl
Copy link
Member

veprbl commented Dec 26, 2019

Thank you!

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 1, 2020
@kira-bruneau @dtzWill
texlab: fix macOS build (NixOS#76544)
dae5607 
(cherry picked from commit 690390d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar Awaiting requested review from doronbehar

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

texlab won't build on macOS
2 participants
@kira-bruneau @veprbl