Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golden-cheetah: Add libusb (ANT+ sensors), 3.5-DEV1903 -> 3.5-RC2X #76172

Merged
merged 3 commits into from Dec 26, 2019
Merged

golden-cheetah: Add libusb (ANT+ sensors), 3.5-DEV1903 -> 3.5-RC2X #76172

merged 3 commits into from Dec 26, 2019

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

I wanted to use ANT+ sensors with GoldenCheetah, now with libusb it's possible.
I tested it using the ANT USB-Stick-m and a handful of ANT+ sensors - works flawlessly.

While at it, I upgraded the version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ocharles

@JohnAZoidberg
golden-cheetah: Enable libusb support
6c8283e 
Makes it possible to use ANT+ sensors using an ANT+ USB transceiver.
@JohnAZoidberg JohnAZoidberg changed the title Golden cheetah libusb golden-cheetah: Add libusb (ANT+ sensors), 3.5-DEV1903 -> 3.5-RC2X Dec 22, 2019
@ofborg ofborg bot requested a review from ocharles December 22, 2019 15:09
ocharles
ocharles approved these changes Dec 22, 2019
View reviewed changes
Copy link
Contributor

@ocharles ocharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

veprbl
veprbl reviewed Dec 22, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, could we add

substituteInPlace src/gcconfig.pri \
  --replace "#DEFINES += NOWEBKIT" "DEFINES += NOWEBKIT"

And replace qtwebkit with qtwebengine?

@JohnAZoidberg
Copy link
Member Author

Good idea, thanks!

@ofborg ofborg bot requested a review from ocharles December 22, 2019 21:24
@veprbl veprbl mentioned this pull request Dec 22, 2019
Closed
69 tasks
@JohnAZoidberg JohnAZoidberg merged commit 25ce30d into NixOS:master Dec 26, 2019
@JohnAZoidberg JohnAZoidberg deleted the golden-cheetah-libusb branch December 26, 2019 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@ocharles ocharles Awaiting requested review from ocharles

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JohnAZoidberg @ocharles @veprbl