Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.jupyterhub: 0.9.4 -> 1.0.0 #76517

Merged
merged 2 commits into from Dec 29, 2019
Merged

python3Packages.jupyterhub: 0.9.4 -> 1.0.0 #76517

merged 2 commits into from Dec 29, 2019

Conversation

tgys
Copy link
Contributor

@tgys tgys commented Dec 26, 2019 •
edited

Motivation for this change

update jupyterhub to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jonringer @FRidh

@ofborg ofborg bot requested review from cstrahan and ixxie December 26, 2019 00:16
@veprbl
Copy link
Member

veprbl commented Dec 26, 2019

@GrahamcOfBorg build python3Packages.jupyterhub

@FRidh FRidh merged commit dcc96b4 into NixOS:master Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@cstrahan cstrahan Awaiting requested review from cstrahan

@ixxie ixxie Awaiting requested review from ixxie

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tgys @veprbl @FRidh