Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meli: init at alpha-0.5.1 #76519

Merged
merged 1 commit into from Jun 17, 2020
Merged

meli: init at alpha-0.5.1 #76519

merged 1 commit into from Jun 17, 2020

Conversation

erictapen
Copy link
Member

Motivation for this change

This is a new approach to init meli and also would close #69169.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @0x4A6F @matthiasbeyer

@erictapen
Copy link
Member Author

@GrahamcOfBorg build meli

0x4A6F
0x4A6F approved these changes Dec 26, 2019
View reviewed changes
Copy link
Member

@0x4A6F 0x4A6F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Can you run nixpkgs-fmt pkgs/applications/networking/mailreaders/meli/default.nix and rebase?

@erictapen
Copy link
Member Author

@0x4A6F sure

@erictapen erictapen changed the title meli: init at alpha-0.4.2 meli: init at alpha-0.5.1 Apr 24, 2020
drewrisinger
drewrisinger suggested changes May 4, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks/questions.

pkgs/applications/networking/mailreaders/meli/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/mailreaders/meli/default.nix Show resolved Hide resolved
@drewrisinger
Copy link
Contributor

@GrahamcOfBorg build meli

@0x4A6F 0x4A6F mentioned this pull request May 4, 2020
Closed
10 tasks
@ofborg ofborg bot requested a review from 0x4A6F May 4, 2020 19:50
@drewrisinger
Copy link
Contributor

@GrahamcOfBorg build meli

drewrisinger
drewrisinger suggested changes May 5, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more style fixes I missed the first time, then LGTM.

pkgs/applications/networking/mailreaders/meli/default.nix Outdated

src = fetchgit {
url = "https://git.meli.delivery/meli/meli.git";
rev = "${version}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "${version}";
rev = version;

pkgs/applications/networking/mailreaders/meli/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/mailreaders/meli/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/mailreaders/meli/default.nix Show resolved Hide resolved
@erictapen @0x4A6F
meli: init at alpha-0.5.1
4752e21 
Co-authored-by: 0x4A6F <0x4A6F@users.noreply.github.com>
@erictapen
Copy link
Member Author

@drewrisinger Agree to all your suggestions, pushed.

@drewrisinger
Copy link
Contributor

Please resolve above conversations. Approved.

@drewrisinger
Copy link
Contributor

@0x4A6F if you could leave a review too, that'd be great, esp since you're listed as maintainer on this.

drewrisinger
drewrisinger approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review for a reasonable amount of time without any failures (or marked preexisting failures as broken)
  • tested: meli --version, meli

0x4A6F
0x4A6F approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@0x4A6F 0x4A6F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • working on amd64
  • working on aarch64

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/148

@Lassulus Lassulus merged commit 43fc4e0 into NixOS:master Jun 17, 2020
@erictapen
Copy link
Member Author

Yay. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4A6F 0x4A6F 0x4A6F approved these changes

@drewrisinger drewrisinger drewrisinger approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@erictapen @drewrisinger @nixos-discourse @0x4A6F @Lassulus