Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rofi: fix displaying hicolor icons #76302

Merged
merged 1 commit into from Dec 26, 2019
Merged

rofi: fix displaying hicolor icons #76302

merged 1 commit into from Dec 26, 2019

Conversation

kira-bruneau
Copy link
Contributor

Motivation for this change

Fixes rofi not displaying hicolor icons: #76196

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mbakke @Ma27

@kira-bruneau
rofi: fix displaying hicolor icons
b12dfd0 
This adds the hicolor theme to XDG_DATA_DIRS for rofi and moves all
wrapping to rofi/wrapper.nix.

The wrapper will now always be generated, even when a theme is not provided.
@kira-bruneau
Copy link
Contributor Author

@worldofpeace I didn't use wrapGAppsHook because the application isn't a GNOME or GTK app and already has a separate wrapper. Although, this doesn't seem like a very clean solution. Do you think it be better to just use wrapGAppsHook anyway?

@ofborg ofborg bot requested a review from Ma27 December 23, 2019 20:00
@Ma27 Ma27 merged commit 622c199 into NixOS:master Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kira-bruneau @Ma27