haskellPackages.hail: add patches to relax cabal dependencies #72923
Conversation
There was a problem hiding this comment.
@astro In order to get this merged, could you do the following things:
- For each patch, add a link to the PR it comes from and a short description of why it is needed (what it does).
- Ask upstream to make a new release of
hailwith these patches pulled in. Since these patches appear to only be dependency version fixes, it could just be a Hackage revision instead of a full release. If you added a comment to this PR explaining this, and saying which version ofhailyou expect to be working without applying these patches, it would be helpful for the nixpkgs maintainers to know when we can remove these patches. - Remove this line: . You can find an explanation of this here: https://discourse.nixos.org/t/video-tutorial-how-to-fix-broken-haskell-packages-in-nix/3968.
- Change the base branch for this PR to
haskell-updatesinstead ofmaster. Then actually rebase the commit in this PR onto thehaskell-updatesbranch.
|
The first patch is already merged to master, and the second patch is a PR that just needs to be merged. how about contacting @shlevy about this to have both patches in and then simply bumping I would profit from this too, as we use hail in our intranet. |
|
@cdepillabout Thank you for your writeup. I hope to have addressed all concerns. |
Ok, I have asked in the 2nd PR. We still would love to have unbroken Hail in 19.09 rather soon than waiting for a single maintainer. |
| @@ -1292,4 +1292,22 @@ self: super: { | |||
| # https://github.com/Happstack/web-routes-th/pull/3 | |||
| web-routes-th = doJailbreak super.web-routes-th; | |||
|
|
|||
| # Remove for hail > 0.2.0.0 | |||
| @@ -43,7 +43,7 @@ core-packages: | |||
| - ghcjs-base-0 | |||
|
|
|||
| default-package-overrides: | |||
| # LTS Haskell 14.12 | |||
| # LTS Haskell 14.13 | |||
There was a problem hiding this comment.
You don't actually need to regenerate the default-package-overrides part of this file.
In general, @peti will do this once a week a or so.
| @@ -5353,7 +5263,6 @@ broken-packages: | |||
| - Haggressive | |||
| - hahp | |||
| - haiji | |||
| - hail | |||
There was a problem hiding this comment.
All you need to do is remove this line from the broken-packages section.
There was a problem hiding this comment.
Oops, the rest slipped in due to a last test build.
There was a problem hiding this comment.
Actually, no. I need to update the PR's target branch.
| @@ -11942,21 +11942,22 @@ self: { | |||
|
|
|||
| "LDAPv3" = callPackage | |||
| ({ mkDerivation, base, base-encoding, binary, bytestring | |||
| , containers, deepseq, int-cast, newtype, quickcheck-instances | |||
There was a problem hiding this comment.
This file shouldn't be modified either, since @peti does it once a week or so.
|
@astro Thanks for updating this. However, you'll need to do the following things before this can be merged in:
As soon as the above are fixed, I think this should be fine to be merged in. Although when a new release of |
|
@astro Okay, it looks like you fixed everything :-) I'll merge after CI passes. I've confirmed this builds locally. |
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
10.rebuild-darwin: 501+
10.rebuild-darwin: 501-1000
labels
|
Okay, CI has passed, so merging in. @astro Thanks again. This should be available when the haskell package set has been regenerated (usually in a week or so). |
|
Will upload a fixed version of hail to hackage, sorry! |
Motivation for this change
Didn't build.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @ehmry