Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nlohmann_json: disable tests for now since they timeout #72925

Merged
merged 1 commit into from Nov 6, 2019
Merged

nlohmann_json: disable tests for now since they timeout #72925

merged 1 commit into from Nov 6, 2019

Conversation

davidak
Copy link
Member

@davidak davidak commented Nov 6, 2019 •
edited

Motivation for this change

Should fix #72890 and #72717

Workaround for nlohmann/json#1816

Please backport to 19.09 ASAP since the channel is blocked by this!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc grahamc merged commit 4835c83 into NixOS:master Nov 6, 2019
@grahamc
Copy link
Member

grahamc commented Nov 6, 2019

Please backport with git cherry-pick -x 7456f19b40ddd9008275e75c9258e9c3bad38f66 onto the release-19.09 branch and send a PR :)

@davidak davidak deleted the nlohmann_json_disable_tests branch November 6, 2019 21:47
@davidak davidak mentioned this pull request Nov 6, 2019
Merged
10 tasks
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 7, 2019
@grahamc @dtzWill
Merge pull request NixOS#72925 from davidak/nlohmann_json_disable_tests
6804eb4 
nlohmann_json: disable tests for now since they timeout

(cherry picked from commit 4835c83)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nlohmann_json build timed out and blocking stable channel
2 participants
@davidak @grahamc