Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "python: jupyter_console: 5.2.0 -> 6.0.0" #72926

Merged
merged 1 commit into from Nov 6, 2019

Conversation

merijnb
Copy link
Contributor

@merijnb merijnb commented Nov 6, 2019

This reverts commit dc4eb2f. It was
added in a large PR (#71893) by @FRidh, where he already predicted some of
the changes would have to be reverted. This is an obvious one, it breaks
python 2.7 compatibility, as that needs 5.x of jupyter_console.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh

This reverts commit dc4eb2f. It was
added in a large PR (NixOS#71893) by @FRidh, where he already predicted some of
the changes would have to be reverted. This is an obvious one, it breaks
python 2.7 compatibility, as that needs 5.x of jupyter_console.
@jonringer
Copy link
Contributor

in stead of reverting, do you mind freezing for python2? similar to #72211

@merijnb
Copy link
Contributor Author

merijnb commented Nov 6, 2019

This is already "frozen", if you look at top-level/pythonPackages you'll see that 5.nix is only chosen for python versions below 3.5. This change is to a file named 5.nix, which really should be using a version that starts with 5. The default.nix is on 6.0.0 and that rightly sets the disabled flag.

The alternative is just deleting this 5.nix and leaving Python 2.7 users in the cold.

@jonringer
Copy link
Contributor

i see, it was 5.nix

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM

[5 built, 52 copied (253.9 MiB), 42.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72926
3 package were build:
python27Packages.ansible-kernel python27Packages.jupyter python27Packages.jupyter_console

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.ansible-kernel python27Packages.jupyter python27Packages.jupyter_console

@jonringer jonringer merged commit 8b8db86 into NixOS:master Nov 6, 2019
@merijnb merijnb deleted the fix-python27-jupyter_console-5.x branch November 6, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants