-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gem-config: add pg_query #72967
gem-config: add pg_query #72967
Conversation
fa2c594
to
b14a5c0
Compare
We should at least ask upstream to consider adding an option to provide
a prebuild libpgquery -- this is a bit of a hack and I'd rather not do
it if it can be avoided.
|
pg_query = attrs: | ||
let | ||
libpg_query = fetchurl { | ||
url = "https://codeload.github.com/lfittl/libpg_query/tar.gz/10-1.0.1"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would pin the same version of libpg_query for all the released of the pg_query gem. Not sure what's the best option there...
Ideally we would know what version the gem wants to fetch and the ask the user to provide the right sha256 for that version.
Yeah, for now I only wanted to get pghero to work. The best solution I think would be to allow easier repacking of the |
What do you think of passing a custom gemConfig to pghero in that case? On the other hand it's not a new problem, we have the same issue with libv8 and other gems, ... so it's unfair of me to block you on that issue. When putting the whishful thinker hat on, ideally I would like the ruby gems to include what external files they want to download in their gemspec metadata, and standardize where those would be downloaded on disk. If that were the case, bundix could do the prefetch-url dance and then place it in the right place for us at runtime. |
Thank you for your contributions.
|
Closing because the proposed solution is far from ideal. |
Motivation for this change
This is preparation for adding the
pghero
package. Thepg_query
gem would try to download a tarball during compilation and this fixes that behaviour.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @zimbatm @alyssais