Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.geary: add patch for longer client test timeout #72998

Merged
merged 1 commit into from Nov 8, 2019
Merged

gnome3.geary: add patch for longer client test timeout #72998

merged 1 commit into from Nov 8, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

I'm see this test timeout frequently, most often on aarch64 on hydra.
Patch is from debian, which probably noticed the same issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
gnome3.geary: add patch for longer client test timeout
3c0b03a 
I'm see this test timout frequently, most often on aarch64 on hydra.
Patch is from debian, which probably noticed the same issue.
@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Nov 7, 2019
@ofborg ofborg bot requested review from hedning and jtojnar November 7, 2019 20:31
@jtojnar
Copy link
Contributor

jtojnar commented Nov 7, 2019

Michael Gratton is the upstream developer. Is not there an in-tree patch we could use?

@worldofpeace
Copy link
Contributor Author

Michael Gratton is the upstream developer. Is not there an in-tree patch we could use?

Don't think so

Perhaps the goal was to have

which gives all the tests more time to run.

@jtojnar
Copy link
Contributor

jtojnar commented Nov 7, 2019

Aargh, I would expect Debian to be better. At least add mention a patch source.

@worldofpeace
Copy link
Contributor Author

In a recent eval the gnome tests and pantheon test failed because the client tests timed out

https://hydra.nixos.org/build/106049892
https://hydra.nixos.org/build/106051014

@worldofpeace worldofpeace merged commit b859c85 into NixOS:master Nov 8, 2019
@worldofpeace worldofpeace deleted the client-tests-geary branch November 8, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @jtojnar