Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: npyscreen: init at 4.10.5 #72948

Closed
wants to merge 1 commit into from
Closed

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Nov 6, 2019

Motivation for this change

Add python module for tui applications. (e.g. signal-curses)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

sha256 = "0vhjwn0dan3zmffvh80dxb4x67jysvvf1imp6pk4dsfslpwy0bk2";
};

doCheck = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if tests aren't bundled with the pypi tarball, please grab from github https://github.com/npcole/npyscreen.

Tests are crucial to ensure that the package still works. You can disable the tests which don't work well within a sandbox

meta = with lib; {
homepage = "https://npyscreen.readthedocs.io/";
description = "python widget library and application framework for programming terminal or console applications";
license = licenses.bsd3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license = licenses.bsd3;
license = licenses.bsd2;

https://bitbucket.org/npcole/npyscreen/src/default/LICENCE

@Profpatsch
Copy link
Member

(triage) any updates?

@doronbehar
Copy link
Contributor

(triage) any updates?

I think not. Closing.

@doronbehar doronbehar closed this May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants