darwin: fix adoptopenjdk-hotspot-bin-8 build #72950
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
On current master, running
nix-build . -A adoptopenjdk-hotspot-bin-8
results inln: failed to create symbolic link '/nix/store/fkhmgiyh6sh65x0x27wwlsz1m2nv5wrw-adoptopenjdk-hotspot-bin-8.0.222/jre': File exists
.Things done
I make sure that this backwards compatability mechanism isn't breaking builds on older jdk versions, by checking first if the directory exists (and hence the need for this ln -s call).
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @taku0