Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.jsonrpclib-pelix: Remove moredread as maintainer #72852

Merged
merged 1 commit into from Nov 7, 2019
Merged

pythonPackages.jsonrpclib-pelix: Remove moredread as maintainer #72852

merged 1 commit into from Nov 7, 2019

Conversation

Moredread
Copy link
Contributor

Motivation for this change

See #54249

In short, I don't feel comfortable to maintain such a security critical dependency for a cryptocurrency package (electrum etc.) at the moment.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Moredread
Copy link
Contributor Author

cc @ehmry @joachifm @np

@jonringer
Copy link
Contributor

security concerns are largely an upstream issue, all we can do is mark that there are known vulnerabilities, apply patches, or bump the version.

If you don't feel comfortable maintaining it, then I can remove you

@Moredread
Copy link
Contributor Author

Mhh, it looks it isn't a dependency anymore. spesmilo/electrum#4825 spesmilo/electrum@5df5aaa

@jonringer
Copy link
Contributor

if you still want to be removed, let me know, or close the PR if you're fine with continuing on :)

@veprbl
Copy link
Member

veprbl commented Nov 7, 2019

Mhh, it looks it isn't a dependency anymore. spesmilo/electrum#4825 spesmilo/electrum@5df5aaa

Should we remove the whole fork then?

@Moredread
Copy link
Contributor Author

The electrum change hasn't been released yet. But after that I think we can remove , as it isn't used anywhere else jsonrpclib-pelix and modern alternatives exist for the package.

@jonringer
Copy link
Contributor

electron-cash also mentions it,

$ rg jsonrpclib-pelix
pkgs/top-level/python-packages.nix
2577:  jsonrpclib-pelix = callPackage ../development/python-modules/jsonrpclib-pelix {};

pkgs/applications/misc/electron-cash/default.nix
17:    jsonrpclib-pelix

pkgs/applications/misc/electrum/ltc.nix
27:    jsonrpclib-pelix

pkgs/applications/misc/electrum/default.nix
65:    jsonrpclib-pelix

pkgs/development/python-modules/jsonrpclib-pelix/default.nix
7:  pname = "jsonrpclib-pelix";
19:    homepage = https://pypi.python.org/pypi/jsonrpclib-pelix/;

@Moredread
Copy link
Contributor Author

:/ OK in that case please remove me after all please. :)

@jonringer jonringer merged commit b417fed into NixOS:master Nov 7, 2019
@Moredread Moredread deleted the maintainer-removal branch November 7, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Moredread @jonringer @veprbl