Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protocol: 20171226 -> 2019-03-28 #72919

Merged
merged 1 commit into from Nov 14, 2019
Merged

protocol: 20171226 -> 2019-03-28 #72919

merged 1 commit into from Nov 14, 2019

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

It's been quite a while.

Things done

Tested the newly supported DHCP protocol:

./result/bin/protocol dhcp
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @teto

@ofborg ofborg bot requested a review from teto November 6, 2019 18:56
@teto
Copy link
Member

teto commented Nov 7, 2019

I dont think there is any stable version (it's not on pypi, isn't it ?) so I am not for changing the name. Other than that ok

@JohnAZoidberg
Copy link
Member Author

No, the protocol on pypi is something else.
I changed the name to comply with the guidelines.

@teto teto merged commit a2aaa7c into NixOS:master Nov 14, 2019
@JohnAZoidberg JohnAZoidberg deleted the protocol-2019 branch November 14, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto Awaiting requested review from teto

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JohnAZoidberg @teto