Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apache-directory-studio: 2.0.0.v20170904-M13 -> 2.0.0-M14 #72920

Merged
merged 1 commit into from Nov 6, 2019
Merged

apache-directory-studio: 2.0.0.v20170904-M13 -> 2.0.0-M14 #72920

merged 1 commit into from Nov 6, 2019

Conversation

JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Nov 6, 2019 •
edited

Motivation for this change

New release :)
https://directory.apache.org/studio/changelog.html

Removed the date in version because upstream only has that in their download URL, not really in the version number.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bjornfor

@JohnAZoidberg JohnAZoidberg changed the title apache-directory-studio: 2.0.0.v20170904-M13 -> 2.0.0.v20180908-M14 apache-directory-studio: 2.0.0.v20170904-M13 -> 2.0.0-M14 Nov 6, 2019
@ofborg ofborg bot requested a review from bjornfor November 6, 2019 18:59
@bjornfor bjornfor merged commit 9221668 into NixOS:master Nov 6, 2019
@JohnAZoidberg JohnAZoidberg deleted the apache-directory-studio-M14 branch November 6, 2019 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JohnAZoidberg @bjornfor