Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mattermost-desktop: 4.2.3 -> 4.3.1 #72867

Merged
merged 2 commits into from Nov 6, 2019
Merged

Mattermost-desktop: 4.2.3 -> 4.3.1 #72867

merged 2 commits into from Nov 6, 2019

Conversation

evils
Copy link
Member

@evils evils commented Nov 6, 2019 •
edited

Motivation for this change

mattermost-desktop crashed on opening the file chooser

Things done

add wrapGAppsHook and pass dependencies
bump version (unrelated)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jokogr

@ofborg ofborg bot requested a review from jokogr November 6, 2019 01:13
lsix
lsix approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@lsix lsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested locally. Good for me.

jokogr
jokogr approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@jokogr jokogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested, too, thanks for the fix and the update! 👍

@jokogr jokogr merged commit fc323c2 into NixOS:master Nov 6, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 6, 2019
@jokogr @dtzWill
Merge pull request NixOS#72867 from Evils-Devils/mattermost-filechooser
ce0cab3 
Mattermost-desktop: 4.2.3 -> 4.3.1
(cherry picked from commit fc323c2)
@knedlsepp
Copy link
Member

@jokogr: Could we get this backported to 19.09?

@evils evils deleted the mattermost-filechooser branch November 10, 2019 15:26
@jokogr jokogr mentioned this pull request Nov 24, 2019
Merged
10 tasks
@knedlsepp
Copy link
Member

Does this work for anybody? I'm still having issues with that on 20.03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsix lsix lsix approved these changes

@jokogr jokogr jokogr approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@evils @knedlsepp @lsix @jokogr