pyfda: init at 0.2.1 #72875
Closed
pyfda: init at 0.2.1 #72875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnAZoidberg
requested changes
Nov 6, 2019
There was a problem hiding this comment.
Does it work for you?
When I try to start it, it fails to find the QT plugins:
> ./result/bin/pyfdax
[ INFO] [pyfda.pyfda_rc:191] Using 'DejaVu Sans' font.
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.
fish: “./result/bin/pyfdax” terminated by signal SIGABRT (Abort)
Yes, when the nixpkgs versions used for pyfda is the same as the one currently running on the system. Otherwise, I get the same error also. |
sbourdeauducq
force-pushed
the
for-upstream
branch
from
cb0c78c
to
b7b6664
Compare
|
Thanks for the suggestions, I have implemented them. |
sbourdeauducq
force-pushed
the
for-upstream
branch
2 times, most recently
from
34a0d57
to
07fb994
Compare
|
This is missing wrapQtAppsHook diff --git a/pkgs/applications/science/misc/pyfda/default.nix b/pkgs/applications/science/misc/pyfda/default.nix
index 791b4be1454..e325a05e80d 100644
--- a/pkgs/applications/science/misc/pyfda/default.nix
+++ b/pkgs/applications/science/misc/pyfda/default.nix
@@ -1,15 +1,16 @@
-{ lib, buildPythonApplication, fetchPypi, numpy, scipy, matplotlib, pyqt5, docutils, nmigen }:
+{ lib, python3Packages, wrapQtAppsHook }:
-buildPythonApplication rec {
+python3Packages.buildPythonApplication rec {
pname = "pyfda";
version = "0.2.1";
- src = fetchPypi {
+ src = python3Packages.fetchPypi {
inherit pname version;
sha256 = "11whn2hhr0szbzpmly2p47prvsm2rhizf60iz3pfgkbrnrjs7mhv";
};
- propagatedBuildInputs = [ numpy scipy matplotlib pyqt5 docutils nmigen ];
+ nativeBuildInputs = [ wrapQtAppsHook ];
+ propagatedBuildInputs = with python3Packages; [ numpy scipy matplotlib pyqt5 docutils nmigen ];
patches = [ ./nmigen.diff ];
postPatch = ''
@@ -28,6 +29,10 @@ buildPythonApplication rec {
export HOME=`mktemp -d`
'';
+ postInstall = ''
+ wrapQtApp "$out"/bin/pyfdax
+ '';
+
meta = with lib; {
description = "Python filter design analysis tool";
homepage = "https://github.com/chipmuenk/pyfda";
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 53eb951db7d..bd7a43e3b09 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -23789,7 +23789,7 @@ in
openmolcas = callPackage ../applications/science/chemistry/openmolcas { };
- pyfda = python3Packages.callPackage ../applications/science/misc/pyfda { };
+ pyfda = libsForQt5.callPackage ../applications/science/misc/pyfda { };
pymol = callPackage ../applications/science/chemistry/pymol { };
|
|
@sbourdeauducq can you please add the qt-wrapper? |
sbourdeauducq
force-pushed
the
for-upstream
branch
from
07fb994
to
16ddedf
Compare
|
Done, sorry about the delay |
JohnAZoidberg
requested changes
Feb 21, 2020
| nativeBuildInputs = [ wrapQtAppsHook ]; | ||
| propagatedBuildInputs = with python3Packages; [ numpy scipy matplotlib pyqt5 docutils nmigen ]; | ||
|
|
||
| patches = [ ./nmigen.diff ]; |
There was a problem hiding this comment.
Could you please add a short comment explaining why this patch is necessary and why you choose nmigen instead of migen?
Could this be upstreamed?
| --replace "'pyfdax_no_term = pyfda.pyfdax:main'," "" | ||
|
|
||
| # This code is unused but causes problems with Py3.7 due to the async keyword. | ||
| rm pyfda/fixpoint_widgets/iir_df1.py |
There was a problem hiding this comment.
Could this be upstreamed?
| description = "Python filter design analysis tool"; | ||
| homepage = "https://github.com/chipmuenk/pyfda"; | ||
| license = licenses.mit; | ||
| maintainers = [ maintainers.sb0 ]; |
There was a problem hiding this comment.
Could you please put a platforms attribute?
There was a problem hiding this comment.
Actually, this is not required for a python module.
There was a problem hiding this comment.
It is not required if it is all.
This comment has been minimized.
This comment has been minimized.
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing due to inactivity from author. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add a nice digital filter design tool.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)