-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyfda: init at 0.2.1 #72875
pyfda: init at 0.2.1 #72875
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it work for you?
When I try to start it, it fails to find the QT plugins:
> ./result/bin/pyfdax
[ INFO] [pyfda.pyfda_rc:191] Using 'DejaVu Sans' font.
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.
fish: “./result/bin/pyfdax” terminated by signal SIGABRT (Abort)
Yes, when the nixpkgs versions used for pyfda is the same as the one currently running on the system. Otherwise, I get the same error also. |
cb0c78c
to
b7b6664
Compare
Thanks for the suggestions, I have implemented them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On minor nitpick
34a0d57
to
07fb994
Compare
This is missing wrapQtAppsHook diff --git a/pkgs/applications/science/misc/pyfda/default.nix b/pkgs/applications/science/misc/pyfda/default.nix
index 791b4be1454..e325a05e80d 100644
--- a/pkgs/applications/science/misc/pyfda/default.nix
+++ b/pkgs/applications/science/misc/pyfda/default.nix
@@ -1,15 +1,16 @@
-{ lib, buildPythonApplication, fetchPypi, numpy, scipy, matplotlib, pyqt5, docutils, nmigen }:
+{ lib, python3Packages, wrapQtAppsHook }:
-buildPythonApplication rec {
+python3Packages.buildPythonApplication rec {
pname = "pyfda";
version = "0.2.1";
- src = fetchPypi {
+ src = python3Packages.fetchPypi {
inherit pname version;
sha256 = "11whn2hhr0szbzpmly2p47prvsm2rhizf60iz3pfgkbrnrjs7mhv";
};
- propagatedBuildInputs = [ numpy scipy matplotlib pyqt5 docutils nmigen ];
+ nativeBuildInputs = [ wrapQtAppsHook ];
+ propagatedBuildInputs = with python3Packages; [ numpy scipy matplotlib pyqt5 docutils nmigen ];
patches = [ ./nmigen.diff ];
postPatch = ''
@@ -28,6 +29,10 @@ buildPythonApplication rec {
export HOME=`mktemp -d`
'';
+ postInstall = ''
+ wrapQtApp "$out"/bin/pyfdax
+ '';
+
meta = with lib; {
description = "Python filter design analysis tool";
homepage = "https://github.com/chipmuenk/pyfda";
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 53eb951db7d..bd7a43e3b09 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -23789,7 +23789,7 @@ in
openmolcas = callPackage ../applications/science/chemistry/openmolcas { };
- pyfda = python3Packages.callPackage ../applications/science/misc/pyfda { };
+ pyfda = libsForQt5.callPackage ../applications/science/misc/pyfda { };
pymol = callPackage ../applications/science/chemistry/pymol { };
|
@sbourdeauducq can you please add the qt-wrapper? |
07fb994
to
16ddedf
Compare
Done, sorry about the delay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Now with the qtwrapper it starts properly and looks like it's working.
nativeBuildInputs = [ wrapQtAppsHook ]; | ||
propagatedBuildInputs = with python3Packages; [ numpy scipy matplotlib pyqt5 docutils nmigen ]; | ||
|
||
patches = [ ./nmigen.diff ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a short comment explaining why this patch is necessary and why you choose nmigen instead of migen?
Could this be upstreamed?
--replace "'pyfdax_no_term = pyfda.pyfdax:main'," "" | ||
# This code is unused but causes problems with Py3.7 due to the async keyword. | ||
rm pyfda/fixpoint_widgets/iir_df1.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be upstreamed?
description = "Python filter design analysis tool"; | ||
homepage = "https://github.com/chipmuenk/pyfda"; | ||
license = licenses.mit; | ||
maintainers = [ maintainers.sb0 ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please put a platforms
attribute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this is not required for a python module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not required if it is all.
This comment has been minimized.
This comment has been minimized.
I marked this as stale due to inactivity. → More info |
Closing due to inactivity from author. |
Motivation for this change
Add a nice digital filter design tool.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)