Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpm: 4.14.2.1 -> 4.15.1 #72956

Merged
merged 1 commit into from
Jun 15, 2020
Merged

rpm: 4.14.2.1 -> 4.15.1 #72956

merged 1 commit into from
Jun 15, 2020
+8 −6

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

https://rpm.org/wiki/Releases/4.15.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @copumpkin

Sorry, something went wrong.

@ofborg ofborg bot requested a review from copumpkin November 7, 2019 00:15
@mmahut
Copy link
Member

mmahut commented Nov 7, 2019 

configure: error: Python interpreter is too old```

@JohnAZoidberg
Copy link
Member Author

JohnAZoidberg commented Nov 7, 2019 •
edited
Loading

Ooops, forgot to commit all-packages.nix.
Thanks :)

c0bw3b
c0bw3b reviewed Nov 8, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 72956 1

1 package are marked as broken and were skipped:
  • osquery (python37Packages.rpm)
6 package failed to build:
  • lattice-diamond (python37Packages.rpm)
  • oracleXE (python37Packages.rpm)
  • plex (python37Packages.rpm)
  • plexRaw (python37Packages.rpm)
  • python27Packages.koji (python37Packages.rpm)
  • python27Packages.rpm (python37Packages.rpm)
43 package were build:
  • aliza (python37Packages.rpm)
  • arrayfire (python37Packages.rpm)
  • aucdtect (python37Packages.rpm)
  • bluejeans-gui (python37Packages.rpm)
  • clair (python37Packages.rpm)
  • clickshare-csc1 (python37Packages.rpm)
  • createrepo_c (python37Packages.rpm)
  • dell-530cdn (python37Packages.rpm)
  • diffoscope (python37Packages.rpm)
  • doodle (python37Packages.rpm)
  • drawio (python37Packages.rpm)
  • dsseries (python37Packages.rpm)
  • dtrx (python37Packages.rpm)
  • ec2-utils (python37Packages.rpm)
  • epkowa (python37Packages.rpm)
  • epm (python37Packages.rpm)
  • epson-201106w (python37Packages.rpm)
  • epson-workforce-635-nx625-series (python37Packages.rpm)
  • epson_201207w (python37Packages.rpm)
  • flatpak-builder (python37Packages.rpm)
  • forge (python37Packages.rpm)
  • gnunet (python37Packages.rpm)
  • gnunet_git (python37Packages.rpm)
  • gutenprintBin (python37Packages.rpm)
  • hpmyroom (python37Packages.rpm)
  • hydra (python37Packages.rpm)
  • intel-ocl (python37Packages.rpm)
  • libextractor (python37Packages.rpm)
  • libsolv (python37Packages.rpm)
  • megacli (python37Packages.rpm)
  • mkl (python37Packages.rpm)
  • postscript-lexmark (python37Packages.rpm)
  • python27Packages.mkl-service (python37Packages.rpm)
  • python27Packages.rhpl (python37Packages.rpm)
  • python37Packages.mkl-service (python37Packages.rpm)
  • rpm (python37Packages.rpm)
  • python38Packages.mkl-service (python37Packages.rpm)
  • python38Packages.rpm (python37Packages.rpm)
  • rpm-ostree (python37Packages.rpm)
  • rpmextract (python37Packages.rpm)
  • vdrPlugins.xineliboutput (python37Packages.rpm)
  • vk-messenger (python37Packages.rpm)
  • yandex-disk (python37Packages.rpm)
  • lattice-diamond and oracleXE failed only because I don't have the sources prefetched in my store
  • plex and plexRaw because unfree
  • python27Packages.rpm and python27Packages.koji are new failures

Logs from python27Packages.rpm are explicit:

checking whether python3 version is >= 2.7... no
configure: error: Python interpreter is too old

-> it's now Py3 only

jonringer
jonringer reviewed Nov 9, 2019
View reviewed changes
pkgs/top-level/python-packages.nix Outdated
@@ -18,7 +18,7 @@ let
packages = ( self:

let
inherit (python.passthru) isPy27 isPy33 isPy34 isPy35 isPy36 isPy37 isPy38 isPy3k isPyPy pythonAtLeast pythonOlder;
inherit (python.passthru) isPy27 isPy2 isPy33 isPy34 isPy35 isPy36 isPy37 isPy38 isPy3k isPyPy pythonAtLeast pythonOlder;
Copy link
Contributor

@jonringer jonringer Nov 9, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FRidh this used to be exported, and is still set on python itself, was isPy2 removed for a reason?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it was removed because !isPy3k achieves the same and because the naming was inconsistent with isPy3k.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.

  • !isPy3k is technically wrong when we want to express that it only works in Python 2.x and will break when Python 4 is released
  • Py3k is not wrongly named, it was/is a name used for Python 3

But yeah, if we've migrated away from it already, I'll do that here, too.

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@JohnAZoidberg
rpm: 4.14.2.1 -> 4.15.1
f56b703 
It's only compatible with Python3 now.
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 8, 2020
@JohnAZoidberg
Copy link
Member Author

Result of nixpkgs-review pr 72956 1

1 package marked as broken and skipped:
  • python27Packages.libmodulemd
5 package failed to build:
  • aliza
  • lattice-diamond
  • libmodulemd_1
  • oracleXE
  • rpm-ostree
49 package built:
  • aucdtect
  • bluejeans-gui
  • clair
  • clickshare-csc1
  • clmagma
  • createrepo_c
  • dell-530cdn
  • diffoscope
  • doodle
  • drawio
  • dsseries
  • dtrx
  • ec2-utils
  • epkowa
  • epm
  • epson-201106w
  • epson-workforce-635-nx625-series
  • epson_201207w
  • flatpak-builder
  • gnunet
  • gnunet_git
  • gutenprintBin
  • hpmyroom
  • hydra-migration
  • hydra-unstable
  • intel-ocl
  • libextractor
  • libmodulemd
  • libsolv
  • megacli
  • mkl
  • plex
  • plexRaw
  • postscript-lexmark
  • python27Packages.mkl-service
  • python27Packages.rhpl
  • python37Packages.libmodulemd
  • python37Packages.mkl-service
  • python37Packages.osc
  • rpm (python37Packages.rpm)
  • python38Packages.libmodulemd
  • python38Packages.mkl-service
  • python38Packages.osc
  • python38Packages.rpm
  • rpmextract
  • scaleft
  • vdrPlugins.xineliboutput
  • vk-messenger
  • yandex-disk

@JohnAZoidberg JohnAZoidberg changed the title rpm: 4.14.2.1 -> 4.15.0 rpm: 4.14.2.1 -> 4.15.1 Jun 10, 2020
@JohnAZoidberg
Copy link
Member Author

JohnAZoidberg commented Jun 10, 2020 •
edited
Loading

It looks like those other 5 failures are unrelated to rpm.
Their build logs are totally empty.
@GrahamcOfBorg build rpm-ostree oracleXE libmodulemd_1 lattice-diamond aliza

@JohnAZoidberg JohnAZoidberg merged commit 5f5caac into NixOS:master Jun 15, 2020
@JohnAZoidberg JohnAZoidberg deleted the rpm-415 branch June 15, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@c0bw3b c0bw3b

@copumpkin copumpkin

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JohnAZoidberg @mmahut @FRidh @jonringer @c0bw3b