Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R: enable tcltk on darwin #72954

Merged
merged 1 commit into from Nov 7, 2019

Conversation

nkpart
Copy link
Contributor

@nkpart nkpart commented Nov 6, 2019

Motivation for this change

tcltk was switched off for Darwin in R when support for Darwin was added in a225a65.

I have tested this patch on Catalina (10.15) and High Sierra (10.13). R successfully builds and the following program displays a frame

Test done:

nix-shell -p '(import ./. {}).R' --pure --run R

> library(tcltk)
> tkframe(tktoplevel())

Note existence of frame.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@nkpart nkpart requested a review from peti as a code owner November 6, 2019 23:47
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 labels Nov 6, 2019
@matthewbauer matthewbauer merged commit 551d9f6 into NixOS:master Nov 7, 2019
@nkpart nkpart deleted the nkpart/R-darwin-enable-tcltk branch November 7, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants