Improve scroll to text WPT coverage. #20105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 6, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1900648
branch
from
2c32f73
to
7604ceb
Compare
Adds many tests to the scroll to text WPT suite: - Setting window.location.fragmentDirective has no effect - All combinations of optional parameters in text directive - Matching TextMatchChars and PercentEncodedChars (in particular the syntactical characters '&', ‘,’ and ‘-’) including non-ASCII - Multiple matches in the page - Cross-whitespace/node matching (i.e. context terms and match terms can be separated by whitespace and node boundaries) Also added a readable description to each test case. Note all tests pass in Chrome except for non-ASCII character matching. Change-Id: I2a692049ba81bef5412e7b73909fbcdc710eb0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900648 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713057}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1900648
branch
from
7604ceb
to
dbebdcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds many tests to the scroll to text WPT suite:
syntactical characters '&', ‘,’ and ‘-’) including non-ASCII
can be separated by whitespace and node boundaries)
Also added a readable description to each test case.
Note all tests pass in Chrome except for non-ASCII character matching.
Change-Id: I2a692049ba81bef5412e7b73909fbcdc710eb0da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900648
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713057}