Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RNNoise, use it in Mumble #72870

Merged
merged 2 commits into from
Nov 7, 2019
Merged

Add RNNoise, use it in Mumble #72870

merged 2 commits into from
Nov 7, 2019
+27 −1

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Nov 6, 2019 •
edited
Loading

Motivation for this change

Vastly improves suppression of background and typing noises.

image

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

Me as new maintainer.

@chpatrick to test, then we can remove WIP.

Sorry, something went wrong.

@nh2 nh2 changed the title WIP: Add RNNoise, use it in mumble WIP: Add RNNoise, use it in Mumble Nov 6, 2019
@nh2 nh2 requested review from infinisil and chpatrick November 6, 2019 02:24
@nh2
Copy link
Contributor Author

nh2 commented Nov 6, 2019

CC @clefru because I got RNNoise from your NUR, so you may like this upstreaming.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 6, 2019
@chpatrick
Copy link
Contributor

Works for me!

@nh2 nh2 changed the title WIP: Add RNNoise, use it in Mumble Add RNNoise, use it in Mumble Nov 6, 2019
@nh2 nh2 merged commit b618df3 into NixOS:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil

@chpatrick chpatrick

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nh2 @chpatrick