Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncmpc: 0.35 -> 0.36 #73000

Merged
merged 1 commit into from Nov 8, 2019
Merged

ncmpc: 0.35 -> 0.36 #73000

merged 1 commit into from Nov 8, 2019

Conversation

phi-gamma
Copy link
Contributor

New release fixing a crash that affects nixos due to the build without
pcre. https://github.com/MusicPlayerDaemon/ncmpc/releases/tag/v0.36

Motivation for this change

Upstream released a new version fixing a flaw that affects nixos in particular.

Things done

Functionality testing on 19.09.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@phi-gamma
ncmpc: 0.35 -> 0.36
245f5ec 
New release fixing a crash that affects nixos due to the build without
pcre. https://github.com/MusicPlayerDaemon/ncmpc/releases/tag/v0.36
@ofborg ofborg bot requested a review from fpletz November 7, 2019 21:12
fpletz
fpletz approved these changes Nov 8, 2019
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will also backport to 19.09.

@fpletz fpletz merged commit 5aed8a9 into NixOS:master Nov 8, 2019
@fpletz
Copy link
Member

fpletz commented Nov 8, 2019

Oh, I just realized we have 0.34 in 19.09. Do you know if this bug also affects 0.34?

@phi-gamma
Copy link
Contributor Author

Do you know if this bug also affects 0.34?

At least the spurious assert which caused the uninitialized access
was there in 0.34. I’m also certain the issue is present with the
ncmpc in 19.03 and 19.09 because I kept being annoyed by it. ;-)

@fpletz
Copy link
Member

fpletz commented Nov 8, 2019

Thanks! Backporting... 😃

@phi-gamma
Copy link
Contributor Author

phi-gamma commented Nov 8, 2019 •
edited

Thanks! Will also backport to 19.09.

What version of mpd does 19.09 ship? I’ve had issues running
v0.36 against the mpd in 19.03 due to an API mismatch. IIRC the
“tagtypes” query doesn’t support arguments in older mpd versions,
but ncmpc is using that query as of v0.36. I can confirm that the mpd
from nixpkgs master works fine though.

I’m not on nixos right now (work) so I can’t check myself.

@fpletz
Copy link
Member

fpletz commented Nov 8, 2019

Hmm, weird, we seem to have mpd 0.20.23 on master, 19.09 and even 19.03.

@phi-gamma
Copy link
Contributor Author

Was the mpd in 19.03 backported?

More specifically, we need this commit:
MusicPlayerDaemon/MPD@29453ba

@fpletz
Copy link
Member

fpletz commented Nov 8, 2019

There doesn't seem to have been any bumps of mpd since December 2018. So no backport to 19.03.

Okay, in that case I'll better revert the ncmpc bump for now on 19.09. We definitely don't want to bump mpd on the stable branches to 0.21 or apply that patch as it adds a new feature.

Thanks a lot for the explanations and the research! We should bump mpd on master soon. :)

@phi-gamma phi-gamma mentioned this pull request Nov 9, 2019
Closed
6 tasks
@phi-gamma
Copy link
Contributor Author

in that case I'll better revert the ncmpc bump for now on 19.09. We definitely don't want to bump mpd on the stable branches to 0.21 or apply that patch as it adds a new feature.

How about just adding the patch then? It’s a one line fix.

We should bump mpd on master soon.

Agreed, #73112 !

pacien added a commit to pacien/nixpkgs that referenced this pull request Nov 16, 2019
@pacien
Revert "ncmpc: 0.35 -> 0.36"
7d2b904 
ncmpc 0.36 isn't compatible with mpd 0.20 which is the version packaged on
the release-19.09 branch.

See NixOS#73000 (comment).

This reverts commit 245f5ec.
@pacien pacien mentioned this pull request Nov 16, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phi-gamma @fpletz