nixos/gnome3: add gnome-flashback to systemd.packages #72959
Merged
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we did the revert of adding gnome-flashback to systemd.packages [0] I forgot to test with other display managers. If we use GDM with gnome-flashback it appears it doesn't try to fallback to non-systemd startup and always fails and starts the regular gnome-session. So adding gnome-flashback to systemd.packages was perfectly fine, but we did forgot one detail. We need systemd targets for the customSessions which is added using mkSystemdTargetForWm in the gnome- flashback package. [0]: 42f567b
ofborg
bot
added
6.topic: GNOME
jtojnar
approved these changes
Nov 12, 2019
|
Thanks @jtojnar 🌠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
When we did the revert of adding gnome-flashback to systemd.packages 0
I forgot to test with other display managers. If we use GDM with gnome-flashback
it appears it doesn't try to fallback to non-systemd startup and always fails and
starts the regular gnome-session. So adding gnome-flashback to systemd.packages
was perfectly fine, but we did forgot one detail. We need systemd targets for the
customSessions which is added using mkSystemdTargetForWm in the gnome-
flashback package.
This fixes starting gnome-flashback-metacity with gdm and all customSessions with GDM.
Though we still have the issue confirmed in #71212 (comment).
Edit: I have no idea what was going on with my grammar when I wrote this message 😄 I should probably rewrite it.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)