Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.cliff: fix build and add tests #72957

Merged
merged 1 commit into from Nov 18, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 7, 2019

Motivation for this change

noticed it was broken when reviewing other packages

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[2 built (1 failed), 100 copied (707.8 MiB), 103.7 MiB DL]
error: build of '/nix/store/0r1nfh4h5w0ybk5spvdhixnj5gfw2wx2-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/72957
1 package failed to build:
python37Packages.optuna

2 package were build:
python37Packages.cliff python38Packages.cliff

Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, played around a little bit inside an ipython shell

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.cliff python38Packages.cliff

@jonringer jonringer merged commit 60e1709 into NixOS:master Nov 18, 2019
@jonringer jonringer deleted the fix-cliff branch February 13, 2020 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants