-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/awstats: drop module #72961
nixos/awstats: drop module #72961
Conversation
I looked into setting up AWstats a few weeks ago, but after 5 minutes couldn't work out how to use this module. For example, there is no option to specify log locations - it seems like this module assumes you're only serving one website, and that website is using apache. I was planning to roll my own solution - and have been umming and ahing about pushing it upstream. My main concern was breaking backwards compatibility - but if the alternative is removal then that probably isn't a problem. So I'd be happy to take ownership of this and do some refactoring to make it more flexible. |
IIRC awstats started as a prototype written for @tohl, but I suspect it's never made it to practical usage. (And I won't be maintaining it.) |
@aristaeus yeah the module isn't complete, makes far too many assumptions, and only works use under fairly limited scope. I'd love to coordinate with you if you're rewriting this, as my motivation for this PR is changes I'm making to the Thank you! |
prototype written for @tohl, but I suspect it's never made it to
yes, awstats can be removed
|
I also never used this module since I was only interested in the mail stats functionality of awstats which this module didn't support and so I have my own local module just for that. So I would be fine with the module being removed. |
@aristaeus If you plan on also supporting mail stats or would be open to getting support for that into your new module I would love to help out with code and comments from my own hacked together module if it means I no longer have to maintain my own module. |
@griff sounds good. Is your config online somewhere? |
@aristaeus it is now mail-awstats.nix. Please note that it is very hacky and only works for postfix and though there are options for multiple domains it only collects statistics for all the configured postfix domains combined. And if the journald log is very large the first time the hourly service is run it will be very slow because it reads the log twice. |
@griff thanks for providing that! @aristaeus any updates on your progress? |
@aanderse Sorry, I've had a busy couple of weeks. My branch is now looking pretty respectable so I'll submit a PR now. |
Great, thanks! |
Motivation for this change
The
awstats
module has never been maintained after initially added tonixpkgs
and should be removed, or have someone take ownership of it.ping @vcunat @griff
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @