Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cadaver: Enable readline support #72960

Merged
merged 1 commit into from Nov 10, 2019
Merged

cadaver: Enable readline support #72960

merged 1 commit into from Nov 10, 2019

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

It's a pain to use, without readline. With it, common niceties, such as arrow-up for last command, work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @wavewave

@ofborg ofborg bot requested a review from wavewave November 7, 2019 01:40
@aanderse
Copy link
Member

Change looks very simple. Author is @JohnAZoidberg. Good enough for me 👍

@aanderse aanderse merged commit 377e691 into NixOS:master Nov 10, 2019
@JohnAZoidberg JohnAZoidberg deleted the cadaver-readline branch November 10, 2019 13:48
@JohnAZoidberg
Copy link
Member Author

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wavewave wavewave Awaiting requested review from wavewave

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JohnAZoidberg @aanderse