Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs: also allow librsvg dependency when using withNS #72872

Merged
merged 1 commit into from
Nov 6, 2019
Merged

emacs: also allow librsvg dependency when using withNS #72872

merged 1 commit into from
Nov 6, 2019
+2 −2

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Nov 6, 2019

Motivation for this change

This is required to display svg images on darwin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@marsam marsam requested a review from adisbladis as a code owner November 6, 2019 02:59
@ofborg ofborg bot added the 6.topic: emacs Text editor label Nov 6, 2019
@ofborg ofborg bot requested review from jwiegley, lovek323, the-kenny and peti November 6, 2019 03:08
@etu
Copy link
Contributor

etu commented Nov 6, 2019

Let the bot build it on darwin:
@GrahamcOfBorg build emacs

etu
etu approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@etu etu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Should be fine" but I have no way of actually testing this on macOS.

@adisbladis adisbladis merged commit f6501c4 into NixOS:master Nov 6, 2019
@marsam marsam deleted the enable-librsvg-emacs-darwin branch May 31, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu

@vyp vyp

@adisbladis adisbladis

@jwiegley jwiegley

@lovek323 lovek323

@the-kenny the-kenny

@peti peti

Assignees
No one assigned
Labels
6.topic: emacs Text editor 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marsam @etu @vyp @adisbladis