New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ntopng: 2.0 -> 3.8 #72862
ntopng: 2.0 -> 3.8 #72862
Conversation
Built without nedge. * add readline80 for building `third-party/lua-5.3.5` * add mariadb, which is required when building without nedge * add libmaxminddb which is required according to `docs/README.compilation` * fetch `nDPI` version 2.6, which is found and build automatically * update patch 0001: adapt to code reformatting * remove patch 0002: the callback directory must no longer be writable * remove patch 0003: SOCKET is no longer declared
Have you tried, or taken a look at, the ntopng nixos module ( I ask because it mentions redis used for persistent storage, which maybe is something mariadb is used for? Anyway someone should vet the nixos module before moving ahead with this. Shouldn't be anything tricky but I can't say without bouncing into the code/changes/etc. |
buildInputs = [ libpcap/* gnutls libgcrypt*/ libxml2 glib geoip geolite-legacy | ||
sqlite which autoreconfHook git pkgconfig groff curl json_c luajit zeromq | ||
buildInputs = [ libpcap/* gnutls libgcrypt*/ libxml2 libmaxminddb glib geoip geolite-legacy | ||
sqlite which autoreconfHook git pkgconfig groff curl json_c luajit zeromq mariadb readline80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
autoreconfHook
and pkgconfig
belong in nativeBuildInputs
. Maybe which
and groff
too?
+ is git
still necessary now that you fetch nDPI with nix fetchers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
autoreconfHook
andpkgconfig
belong innativeBuildInputs
. Maybewhich
andgroff
too?
Changed.
is git still necessary now that you fetch nDPI with nix fetchers?
The configure script calls git in order to determine the commit hash, but this fails anyway, expectedly:
fatal: not a git repository (or any parent up to mount point /)
I removed it, so now the error / warning is different:
./configure: line 3845: git: command not found
No, I have not tried it. I am also still a bit confused about the ntopng and ntopng-edge separation and what it means; and why the former needs the mysql / mariasql client library, ie. why it is not simply optional.
Matter of fact, it does run without mariadb, just like it did before. It is only an option for dumping:
|
* remove git from buildInputs
Co-Authored-By: Renaud <c0bw3b@users.noreply.github.com>
Oh, one more thing that needs to change is that the new daemon requires one to change the password. The default user/password is accepted, but you have to give a new one. Which does not work currently, since it probably cannot store the password anywhere... |
Actually, password hashes are stored in the Redis store. But somehow changing the password via the web interface does not work. I could only trick it by setting the password and the That way, I could see the main interface, but only for a few seconds - then I was redirected to the login page again. It worked OK in a private tab. Seems we need this patch ntop/ntopng@0770271 |
``` substituteStream(): WARNING: pattern '/bin/rm' doesn't match anything in file 'autogen.sh' ... substituteStream(): WARNING: pattern '/usr/local' doesn't match anything in file 'src/Ntop.cpp' ```
The project unconditionally uses the Lua version part of its source tree as a third party module. They disabled the JIT compiler because of some memory issues.
Testing on Ubuntu 18.04:
Seems to work. |
Instead of building liblua from the third-party folder, use the static library from lua5_3 instead.
Thank you for your contributions.
|
I'll look into this again sooner or later. Also, version 4.0 has been released, which may be even better to integrate. |
I marked this as stale due to inactivity. → More info |
Superseded by #159538 |
Built without nedge.
third-party/lua-5.3.5
docs/README.compilation
nDPI
version 2.6, which is found and build automaticallyMotivation for this change
ntopng 3.8 was released almost a year ago. It makes 2/3 patches unnecessary.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @