Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/dhcpcd: restart dhcpcd if exit hook changed #72931

Merged
merged 1 commit into from Feb 2, 2020
Merged

nixos/dhcpcd: restart dhcpcd if exit hook changed #72931

merged 1 commit into from Feb 2, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 6, 2019

Motivation for this change

Note: this is a fairly opinionated change. I don't consider myself sufficiently experienced with dhcpcd(8) to be sure that this doesn't cause any regressions in some use-cases, so I'd be happy to have several reviews :)

This change ensures that dhcpcd.service is restarted as soon as the
exit hook changes. I use this hook to do additional configuration for my
network (like setting a route via the given gateway to my WireGuard) and
when changing parts of this exit hook I'd expect to get this activated
when switching to my new configuration.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27
nixos/dhcpcd: restart dhcpcd if exit hook changed
51d1821 
This change ensures that `dhcpcd.service` is restarted as soon as the
exit hook changes. I use this hook to do additional configuration for my
network (like setting a route via the given gateway to my WireGuard) and
when changing parts of this exit hook I'd expect to get this activated
when switching to my new configuration.
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jan 27, 2020

@GrahamcOfBorg test networking.scripted

@Ma27
Copy link
Member Author

Ma27 commented Feb 2, 2020

@rnhmjoj anything that keeps us from merging this? :)

rnhmjoj
rnhmjoj approved these changes Feb 2, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I forgot to add a review. I can't think of any downsides coming from this and it seems useful.

@Ma27 Ma27 merged commit c2d2c2d into NixOS:master Feb 2, 2020
@Ma27 Ma27 deleted the restart-dhcp-on-exit-hook-change branch February 2, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ma27 @rnhmjoj