Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jasmin: init at 2.4 #72855

Merged
merged 1 commit into from Nov 10, 2019
Merged

jasmin: init at 2.4 #72855

merged 1 commit into from Nov 10, 2019

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Nov 5, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

JohnAZoidberg
JohnAZoidberg requested changes Nov 6, 2019
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work, did you try to assemble a binary?

Is this maybe a fork worth looking into, since the original hasn't been updated for a decade? https://github.com/Sable/jasmin

pkgs/development/compilers/jasmin/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/jasmin/default.nix Outdated Show resolved Hide resolved
@JohnAZoidberg
Copy link
Member

I tried it. The hello world example here can be assembled and run like:

> ./result/bin/jasmin HelloWorld.jasmin
Generated: HelloWorld.class
> java -cp . HelloWorld
Hello World!

I think it'd be cool, to have a test that tests this, using the test attribute: https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes

@fgaz
Copy link
Member Author

fgaz commented Nov 6, 2019

About the fork: I'm not sure. It says "a specialized version of jasmin which is used as a back end for the Soot framework" and the original project does not link to it, so I'm a bit hesitant. Maybe we can merge this and decide later whether to upgrade?

About test: cool, I didn't know about that. Is it new? I'll add it shortly.

@fgaz
Copy link
Member Author

fgaz commented Nov 6, 2019

Also most distros do not package that fork: https://repology.org/project/jasmin/versions

@fgaz
Copy link
Member Author

fgaz commented Nov 6, 2019

Added the test

JohnAZoidberg
JohnAZoidberg approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
Yeah, the fork looks a bit dodgy.

@JohnAZoidberg JohnAZoidberg merged commit f7ef1a9 into NixOS:master Nov 10, 2019
@fgaz fgaz deleted the jasmin/init branch May 11, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fgaz @JohnAZoidberg