Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcv-rack: 1.1.5 -> 1.1.6 #72851

Merged
merged 1 commit into from Nov 18, 2019
Merged

vcv-rack: 1.1.5 -> 1.1.6 #72851

merged 1 commit into from Nov 18, 2019

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Nov 5, 2019 •
edited

Motivation for this change

It looks like upstream is about to release version 1.1.6 soon. I have updated the derivation for the latest master branch commit, trying out if we can drop one of our patches for 1.1.6.

To avoid duplicated effort I post it here already.

1.1.6 has been released.

I added a few more explanatory comments. Please let me know if they are helpful or they can be improved.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Moredread
Copy link
Contributor Author

cc @nathyong

@Moredread Moredread changed the title (WIP) vcv-rack: 1.1.5 -> 1.1.6 vcv-rack: 1.1.5 -> 1.1.6 Nov 18, 2019
Lassulus
Lassulus approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, works as expected

@Lassulus Lassulus merged commit 001f08f into NixOS:master Nov 18, 2019
@Moredread Moredread deleted the rack-1.1.6 branch November 18, 2019 22:30
@maxkrieger
Copy link

How do you use plugins? It seems like Fundamental isn't preinstalled, and this derivation doesn't have the plugin support that #33132 had i.e. https://github.com/NixOS/nixpkgs/pull/33132/files#diff-0a96701bbd982f577aab66458a659b5e

@Lassulus
Copy link
Member

If I remember correctly, I created an account and chose the plugins interactively.

@Moredread
Copy link
Contributor Author

The way @Lassulus described is the way to go. At the moment there is no method to install plugins via Nix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Moredread @maxkrieger @Lassulus