Reassign snap areas when adding snap container #20151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 7, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1900920
branch
3 times, most recently
from
e626489
to
c8fefab
Compare
Making a container scrollable should make it a valid snap container. In doing so, any descendant snap area that should be assigned to the container should be reassigned as such. Bug: 1007456 Change-Id: Iccd220311ce592f921dc8424780632e499d3201c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900920 Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Kaan Alsan <alsan@google.com> Cr-Commit-Position: refs/heads/master@{#717011}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1900920
branch
from
c8fefab
to
e1f9541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a container scrollable should make it a valid snap container.
In doing so, any descendant snap area that should be assigned to the
container should be reassigned as such.
Bug: 1007456
Change-Id: Iccd220311ce592f921dc8424780632e499d3201c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900920
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Kaan Alsan <alsan@google.com>
Cr-Commit-Position: refs/heads/master@{#717011}