[taskcluster] Disable Chrome sandboxing in Docker #20152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgraham
previously approved these changes
Nov 7, 2019
Hexcles
commented
Nov 7, 2019
Whenever we see TASKCLUSTER_ROOT_URL in the entry point (runl.py), we disable Chrome sandboxing with --no-sandbox. Fix #20133
Hexcles
force-pushed
the
chrome-no-sandbox2
branch
from
954ffb5
to
a175c9c
Compare
|
Turns out I was looking at the wrong |
Even though we don't really rely on this env var in this suite for now, it makes sense to have it everywhere for consistency.
wpt-pr-bot
added
the
wptrunner
|
cc @stephenmcgruer this should hopefully pass everything and I've also dropped the debug commits. I need to shoot off now. In case this still fails, could you take a look and talk to James? It'd really be great to have this merged before tomorrow so that we can finish our migration before the deadline. |
|
Ack, will monitor how it goes. |
stephenmcgruer
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we see
TASKCLUSTER_ROOT_URLin the entry point (runl.py), wedisable Chrome sandboxing with --no-sandbox.
tox.ini needs to be modified to allow passing of
TASKCLUSTER_ROOT_URL.Fix #20133
(Alternative to #20136 )