nixos/networkd: add Name as valid option to Link
#72883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been there since v209 [1] ``` The interface name to use. This option has lower precedence than NamePolicy=, so for this setting to take effect, NamePolicy= must either be unset, empty, disabled, or all policies configured there must fail. Also see the example below with "Name=dmz0". Note that specifying a name that the kernel might use for another interface (for example "eth0") is dangerous because the name assignment done by udev will race with the assignment done by the kernel, and only one interface may use the name. Depending on the order of operations, either udev or the kernel will win, making the naming unpredictable. It is best to use some different prefix, for example "internal0"/"external0" or "lan0"/"lan1"/"lan3". ``` [1] systemd/systemd@43b3a5e
fooker
requested review from
adisbladis,
alyssais,
basvandijk,
edolstra,
edwtjo,
Ericson2314,
FRidh,
infinisil,
joachifm,
LnL7,
matthewbauer,
Mic92,
nbp,
peti,
rycee,
thoughtpolice,
ttuegel and
zimbatm
as code owners
ofborg
bot
added
6.topic: emacs
6.topic: erlang
6.topic: GNOME
ofborg
bot
added
6.topic: pantheon
Lassulus
approved these changes
Nov 19, 2019
|
I figured that it makes sense to backport this as well: 76049ce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been there since v209 [1]
[1] systemd/systemd@43b3a5e
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)