ffmpeg: add options for QuickSync and libaom AV1 #72941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to optionally compile with support for Intel's QuickSync hardware accelerated encoding, and libaom AV1 encoding. Set to false by default.
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
10.rebuild-darwin: 101-500
10.rebuild-linux: 501+
10.rebuild-linux: 501-1000
labels
orivej
reviewed
May 23, 2020
| @@ -163,6 +169,8 @@ stdenv.mkDerivation rec { | |||
| bzip2 fontconfig freetype gnutls libiconv lame libass libogg libssh libtheora | |||
| libvdpau libvorbis lzma soxr x264 x265 xvidcore zlib libopus speex nv-codec-headers | |||
| ] ++ optional openglSupport libGLU_combined | |||
| ++ optional libmfxSupport intel-media-sdk | |||
| ++ optional vpxSupport libaom | |||
There was a problem hiding this comment.
Did you mean to use libaomSupport here?
There was a problem hiding this comment.
sorry just seeing this now since your comment happened after the merge. I think you may be right but I can't remember off hand, but it's highly likely to be a typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to optionally compile with support for Intel's QuickSync
hardware accelerated encoding, and libaom AV1 encoding. Set to false by
default.
Also wondering if anybody would like to set any of these to true by default so users don't have to spend hours compiling for these features. If so I will make a separate pr to staging for that, since it will cause a massive rebuild.
cc @codyopel @Fuuzetsu