Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.google_cloud_vision: fix tests #72940

Merged
merged 1 commit into from Nov 11, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 6, 2019

Motivation for this change

noticed it was broken reviewing another package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[2 built, 2 copied (6.1 MiB), 1.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72940
2 package were build:
python37Packages.google_cloud_vision python38Packages.google_cloud_vision

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.google_cloud_vision python38Packages.google_cloud_vision

@jonringer jonringer merged commit 0dfbff1 into NixOS:master Nov 11, 2019
@jonringer jonringer deleted the fix-google-vision branch November 11, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant