Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port remaining test-driver functions to python #72943

Merged
merged 2 commits into from
Nov 7, 2019
Merged

Port remaining test-driver functions to python #72943

merged 2 commits into from
Nov 7, 2019
+13 −0

Conversation

marijanp
Copy link
Contributor

@marijanp marijanp commented Nov 6, 2019

Motivation for this change

Processing the task list in issue #72828.

Implementation of dumpTTYContents and forwardPort.
Note: Both functions are not used in any test so far.

Things done

The functions conform the Black code style.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tfc @flokli @worldofpeace

Sorry, something went wrong.

Marijan added 2 commits November 6, 2019 22:43
nixos/tests: implemented python test-driver version of dumpTTYContents
01f79df
nixos/tests: implemented python test-driver version of forwardPort

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
9915a8c
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 6, 2019
@tfc tfc mentioned this pull request Nov 7, 2019
Closed
@tfc
Copy link
Contributor

tfc commented Nov 7, 2019

@jonringer

@worldofpeace worldofpeace merged commit 1e7ddf2 into NixOS:master Nov 7, 2019
@marijanp marijanp deleted the port-test-driver-python branch November 8, 2019 08:39
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 10, 2019
@worldofpeace @dtzWill
Merge pull request NixOS#72943 from marijanp/port-test-driver-python
17bff57 
Port remaining test-driver functions to python

(cherry picked from commit 1e7ddf2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfc tfc

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marijanp @tfc @worldofpeace