Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vagrant: 2.2.5 -> 2.2.6 #72945

Merged
merged 1 commit into from Dec 4, 2019
Merged

vagrant: 2.2.5 -> 2.2.6 #72945

merged 1 commit into from Dec 4, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 6, 2019

Motivation for this change

https://github.com/hashicorp/vagrant/releases/tag/v2.2.6

Generated the gemset.nix by converting the vagrant.gemspec file to a
different Gemfile as described in the previous update PR[1].

[1] #64302 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27
vagrant: 2.2.5 -> 2.2.6
728f7a7 
https://github.com/hashicorp/vagrant/releases/tag/v2.2.6

Generated the `gemset.nix` by converting the `vagrant.gemspec` file to a
different `Gemfile` as described in the previous update PR[1].

[1] NixOS#64302 (comment)
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 6, 2019
@redvers
Copy link
Member

redvers commented Nov 19, 2019

@aneeshusa
@volth

@Ma27 Ma27 merged commit e855a8e into NixOS:master Dec 4, 2019
@Ma27 Ma27 deleted the bump-vagrant branch December 4, 2019 21:43
@Ma27
Copy link
Member Author

Ma27 commented Dec 4, 2019

Backported as 1be199f.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomfitzhenry tomfitzhenry tomfitzhenry left review comments

@angristan angristan Awaiting requested review from angristan

@manveru manveru Awaiting requested review from manveru

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @redvers @tomfitzhenry