Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gettext: 0.19.8.1 -> 0.20.1 #72946

Merged
merged 1 commit into from Nov 12, 2019
Merged

gettext: 0.19.8.1 -> 0.20.1 #72946

merged 1 commit into from Nov 12, 2019

Conversation

lsix
Copy link
Member

@lsix lsix commented Nov 6, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vrthra @zimbatm

@jtojnar
Copy link
Contributor

jtojnar commented Nov 6, 2019

Interestingly, upstream actually recommends packaging gettext-runtime, libtextstyle (newly introduced) and gettext-tools separately. And they seem to have the projects properly divided each in its own directory.

@lsix
Copy link
Member Author

lsix commented Nov 7, 2019

Yes, you are right.

I’ll have a look into dividing this into different packages.

Do you think we should postpone the update until we have the package split up, or this can be done in 2 steps ?

@jtojnar
Copy link
Contributor

jtojnar commented Nov 7, 2019

Two steps will be fine, as long we do not forget to do the second one.

@FRidh FRidh added this to Needs review in Staging Nov 12, 2019
@FRidh FRidh merged commit 3e267ad into NixOS:staging Nov 12, 2019
Staging automation moved this from Needs review to Done Nov 12, 2019
@jtojnar
Copy link
Contributor

jtojnar commented Nov 12, 2019

Opened #73288 so we do not forget about it.

@FRidh
Copy link
Member

FRidh commented Nov 12, 2019

@FRidh FRidh mentioned this pull request Nov 12, 2019
10 tasks
@jtojnar
Copy link
Contributor

jtojnar commented Nov 12, 2019

cc @NixOS/darwin-maintainers

@worldofpeace
Copy link
Contributor

Is libintl missing?

@ahiaao ahiaao mentioned this pull request Feb 22, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants