Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruplacer: init at 0.4.1 #72971

Merged
merged 2 commits into from Nov 8, 2019
Merged

ruplacer: init at 0.4.1 #72971

merged 2 commits into from Nov 8, 2019

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Nov 7, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@Br1ght0ne Br1ght0ne changed the title Ruplacer 0.4.1 ruplacer: init at 0.4.2 Nov 7, 2019
@Br1ght0ne Br1ght0ne changed the title ruplacer: init at 0.4.2 ruplacer: init at 0.4.1 Nov 7, 2019
@mmahut
Copy link
Member

mmahut commented Nov 7, 2019

@GrahamcOfBorg build ruplacer

@Br1ght0ne
Copy link
Member Author

@mmahut I fixed the MacOS Security thing. r?

@Br1ght0ne Br1ght0ne mentioned this pull request Nov 7, 2019
10 tasks
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 8, 2019

Checking Darwin build:
@GrahamcOfBorg build ruplacer

Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs

Result of nix-review pr 72971 1

1 package were build:
  • ruplacer

$ ./results/ruplacer/bin/ruplacer --color always old new -- test.txt 
Patching test.txt
-- This is old
++ This is new

Would perform 1 replacement on 1 matching file
Re-run ruplacer with --go to write these changes to the filesystem

@c0bw3b c0bw3b merged commit ac8d850 into NixOS:master Nov 8, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 10, 2019
ruplacer: init at 0.4.1
(cherry picked from commit ac8d850)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants