Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topgrade: init at 3.4.0 #72976

Merged
merged 2 commits into from Nov 19, 2019
Merged

topgrade: init at 3.4.0 #72976

merged 2 commits into from Nov 19, 2019

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Nov 7, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@Lassulus
Copy link
Member

sadly I get this error:

hash mismatch in fixed-output derivation '/nix/store/np899m2ffgry6l8s1rg82wp2w9fij50g-topgrade-3.3.0-vendor':
  wanted: sha256:0nwhv7j2wbzh6h4jrxsgcyvqi4sj021k74myj5y44asignacvx3i
  got:    sha256:1fpmd4ykczcg830n2mmikcgnzlcfms9ay0yjan37y877bhi9bkh0
cannot build derivation '/nix/store/m1vy5ksc8gcl38lyv6hybylkwfmgr3z1-topgrade-3.3.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/zhsyazyq0x4a1ygcxyib54hifsf94lbr-env.drv': 1 dependencies couldn't be built

Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix build

@Br1ght0ne Br1ght0ne changed the title topgrade: init at 3.3.0 topgrade: init at 3.4.0 Nov 19, 2019
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, updated my emacs profile with it, (sadly nix didn't work, but thats probably on me)

@Lassulus Lassulus merged commit ae9846c into NixOS:master Nov 19, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 19, 2019
* topgrade: init at 3.4.0

(cherry picked from commit ae9846c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants