Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twmn: Use QT's makeDerivation #72978

Merged
merged 1 commit into from Nov 8, 2019
Merged

twmn: Use QT's makeDerivation #72978

merged 1 commit into from Nov 8, 2019

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

Could not find libQt5Widgets.so.5 and SIBABRTs.
Fixes #20387

Things done

The binaries run and produce sensible output, put I haven't tried to use it for its intended purpose.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matejc

@JohnAZoidberg
twmn: Use QT's makeDerivation
b9c8fb0 
Could not find libQt5Widgets.so.5 and SIBABRTs.
@ofborg ofborg bot requested a review from matejc November 7, 2019 13:35
@aanderse
Copy link
Member

aanderse commented Nov 8, 2019

Thanks @JohnAZoidberg! 🎉

@aanderse aanderse merged commit 7e96693 into NixOS:master Nov 8, 2019
@JohnAZoidberg JohnAZoidberg deleted the twmn-qt-fix branch November 8, 2019 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejc matejc Awaiting requested review from matejc

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

twmnd cant find libQt5Widgets.so.5
2 participants
@JohnAZoidberg @aanderse