[LayoutNG] Null-dereference in LayoutNGListItem::OrdinalValueChanged() #20155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 7, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1902666
branch
2 times, most recently
from
128178b
to
5fed686
Compare
When LayoutNGListItem::OrdinalValueChanged() is called on an ":after" list item element, |marker_| is a nullptr. Similar to LayoutNGListItem::ListStyleTypeChanged(), we need to check that |marker_| is not nullptr before invalidation to avoid null-dereferences in this case. Bug: 1020669 Change-Id: I66913cde0420a3612e881dab9e44a006c276ec64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902666 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#713894}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1902666
branch
from
5fed686
to
345d469
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When LayoutNGListItem::OrdinalValueChanged() is called on an ":after"
list item element, |marker_| is a nullptr.
Similar to LayoutNGListItem::ListStyleTypeChanged(), we need to check
that |marker_| is not nullptr before invalidation to avoid
null-dereferences in this case.
Bug: 1020669
Change-Id: I66913cde0420a3612e881dab9e44a006c276ec64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902666
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713894}